fnmain/jotdown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

prepass: remove unsafe, put strings on heap

Browse source 
actually caused spooky behavior

resolves #5
This commit is contained in:
Noah Hellman 2023-06-14 21:40:56 +02:00
commit 5ddbd728a8
1 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/lib.rs
View file

@ -603,7 +603,7 @@ impl<'s> PrePass<'s> {
) -> Self { ) -> Self {
let mut link_definitions = Map::new(); let mut link_definitions = Map::new();
let mut headings: Vec<Heading> = Vec::new(); let mut headings: Vec<Heading> = Vec::new();
let mut used_ids: Set<&str> = Set::new(); let mut used_ids: Set<String> = Set::new();
let mut blocks = blocks.peekable(); let mut blocks = blocks.peekable();
@ -724,12 +724,7 @@ impl<'s> PrePass<'s> {
} }
} }
// SAFETY: used_ids is dropped before the id_auto strings in headings. even if used_ids.insert(id_auto.clone());
// the strings move due to headings reallocating, the string data on the heap
// will not move
used_ids.insert(unsafe {
std::mem::transmute::<&str, &'static str>(id_auto.as_ref())
});
headings.push(Heading { headings.push(Heading {
location: e.span.start as u32, location: e.span.start as u32,
id_auto, id_auto,